Revert PreImagesRepresentative for IsLinearActionHomomorphism#6395
Closed
fingolfin wants to merge 1 commit into
Closed
Revert PreImagesRepresentative for IsLinearActionHomomorphism#6395fingolfin wants to merge 1 commit into
fingolfin wants to merge 1 commit into
Conversation
This was changed in PR #6232 but the change causes the recog test suite to fail. This looks like a symptom of other deeper issues, but until we can understand and fix this better, let's be pragmatic and revert this for now.
Contributor
ThomasBreuer
left a comment
There was a problem hiding this comment.
I expect that we have to revert all changes related to matrix groups consisting of matrix objects.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6395 +/- ##
===========================================
- Coverage 78.67% 60.06% -18.62%
===========================================
Files 683 635 -48
Lines 292942 252779 -40163
Branches 8658 7461 -1197
===========================================
- Hits 230485 151825 -78660
- Misses 60638 98967 +38329
- Partials 1819 1987 +168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was changed in PR #6232 but the change causes the recog test suite to fail. This looks like a symptom of other deeper issues, but until we can understand and fix this better, let's be pragmatic and revert this for now.
This is being tracked in issue #6389; I propose not to close that right now, though, because we still want to understand the deeper issue better.