Skip to content

Revert PreImagesRepresentative for IsLinearActionHomomorphism#6395

Closed
fingolfin wants to merge 1 commit into
masterfrom
mh/revert-PreImagesRepresentative-IsLinearActionHomomorphism
Closed

Revert PreImagesRepresentative for IsLinearActionHomomorphism#6395
fingolfin wants to merge 1 commit into
masterfrom
mh/revert-PreImagesRepresentative-IsLinearActionHomomorphism

Conversation

@fingolfin
Copy link
Copy Markdown
Member

This was changed in PR #6232 but the change causes the recog test suite to fail. This looks like a symptom of other deeper issues, but until we can understand and fix this better, let's be pragmatic and revert this for now.

This is being tracked in issue #6389; I propose not to close that right now, though, because we still want to understand the deeper issue better.

This was changed in PR #6232 but the change causes the recog test
suite to fail. This looks like a symptom of other deeper issues,
but until we can understand and fix this better, let's be
pragmatic and revert this for now.
@fingolfin fingolfin requested a review from ThomasBreuer May 12, 2026 08:11
@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels May 12, 2026
Copy link
Copy Markdown
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that we have to revert all changes related to matrix groups consisting of matrix objects.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.06%. Comparing base (403924c) to head (f9dece2).

❗ There is a different number of reports uploaded between BASE (403924c) and HEAD (f9dece2). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (403924c) HEAD (f9dece2)
20 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6395       +/-   ##
===========================================
- Coverage   78.67%   60.06%   -18.62%     
===========================================
  Files         683      635       -48     
  Lines      292942   252779    -40163     
  Branches     8658     7461     -1197     
===========================================
- Hits       230485   151825    -78660     
- Misses      60638    98967    +38329     
- Partials     1819     1987      +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fingolfin fingolfin closed this May 16, 2026
@fingolfin fingolfin deleted the mh/revert-PreImagesRepresentative-IsLinearActionHomomorphism branch May 16, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants