Miscellaneous fixes concerning vector and matrix objects#6369
Merged
Conversation
in order to catch `fail` results
Test that the input is square, as for list-of-lists matrices.
- check the input list for `IsPlistRep` in `MakeIsPlistVectorRep`, let `NewVector` turn the input to `IsPlistRep` if necessary - forbid assignments into a `IsPlistVectorRep` vector beyond its length
Conceptually, the solution must be in the same representation as the given vector. (Let us see which other bugs will come to the surface now.)
ThomasBreuer
added
kind: bug
fingolfin
approved these changes
May 11, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6369 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.01%
==========================================
Files 684 684
Lines 292892 292925 +33
Branches 8660 8660
==========================================
+ Hits 230497 230501 +4
- Misses 60581 60608 +27
- Partials 1814 1816 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdwensley
pushed a commit
that referenced
this pull request
May 12, 2026
* add checks to `NewVector`, `NewMatrix` for the GF(2) and 8 bit repres.
in order to catch `fail` results
* add a `String` method for rings `Integers mod n`
* fix the default `OneMutable` method for `IsMatrixObj`
Test that the input is square, as for list-of-lists matrices.
* minor fixes for `IsPlistVectorRep`
- check the input list for `IsPlistRep` in `MakeIsPlistVectorRep`,
let `NewVector` turn the input to `IsPlistRep` if necessary
- forbid assignments into a `IsPlistVectorRep` vector beyond its length
* fix `SolutionMatDestructive`
Conceptually, the solution must be in the same representation
as the given vector.
(Let us see which other bugs will come to the surface now.)
* fix `TestPositionNonZeroInRow`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request consists of those changes from #6342 that are bugfixes.
NewVector,NewMatrixfor the GF(2) and 8 bit representations, in order to catchfailresults,Stringmethod for the ringsIntegers mod n,OneMutablemethod forIsMatrixObj(test that the input is square, as for list-of-lists matrices),IsPlistRepinMakeIsPlistVectorRep, and letNewVectorturn the input toIsPlistRepif necessary (in fact, it had been possible to cause a segmentation fault by callingAddRowVectorwith two input vectors created from ranges),IsPlistVectorRepvector beyond its length.