Skip to content

An/Sn: guard against inputs outside the group#482

Merged
fingolfin merged 1 commit into
masterfrom
mh/guard-an-sn
May 19, 2026
Merged

An/Sn: guard against inputs outside the group#482
fingolfin merged 1 commit into
masterfrom
mh/guard-an-sn

Conversation

@fingolfin
Copy link
Copy Markdown
Member

@fingolfin fingolfin commented May 18, 2026

Extracted from PR #428. Ideally would have a dedicated test (i.e. trying to test membership in An for outsider elements), but then again PR #428 of course also contains a test for the underlying issue...

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.17%. Comparing base (0acc6e4) to head (d30356f).

Files with missing lines Patch % Lines
gap/perm/giant.gi 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   88.18%   88.17%   -0.01%     
==========================================
  Files          45       45              
  Lines       19004    19010       +6     
==========================================
+ Hits        16759    16763       +4     
- Misses       2245     2247       +2     
Files with missing lines Coverage Δ
gap/perm/giant.gi 94.84% <66.66%> (-0.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 347f7b6 into master May 19, 2026
5 of 6 checks passed
@fingolfin fingolfin deleted the mh/guard-an-sn branch May 19, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant