Skip to content

Report source positions for Markdown errors#361

Merged
fingolfin merged 1 commit intomasterfrom
codex/markdown-error-positions
Mar 17, 2026
Merged

Report source positions for Markdown errors#361
fingolfin merged 1 commit intomasterfrom
codex/markdown-error-positions

Conversation

@fingolfin
Copy link
Member

Preserve source locations while parsing and rendering markdown so
unmatched backticks and emphasis markers report the offending file
and line instead of raising a bare Error.

AI assistance: Codex implemented the change and added regression
coverage for markdown syntax errors.

Co-authored-by: Codex codex@openai.com

Preserve source locations while parsing and rendering markdown so
unmatched backticks and emphasis markers report the offending file
and line instead of raising a bare Error.

AI assistance: Codex implemented the change and added regression
coverage for markdown syntax errors.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin enabled auto-merge (squash) March 17, 2026 13:46
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 95.80838% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.14%. Comparing base (37976b8) to head (3b1375b).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
gap/Markdown.gi 91.80% 5 Missing ⚠️
gap/Parser.gi 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   92.94%   93.14%   +0.19%     
==========================================
  Files          13       13              
  Lines        2779     2918     +139     
==========================================
+ Hits         2583     2718     +135     
- Misses        196      200       +4     
Files with missing lines Coverage Δ
gap/DocumentationTree.gi 96.07% <100.00%> (-0.01%) ⬇️
gap/ToolFunctions.gd 100.00% <100.00%> (ø)
gap/ToolFunctions.gi 94.57% <100.00%> (+1.10%) ⬆️
gap/Parser.gi 96.64% <91.30%> (-0.03%) ⬇️
gap/Markdown.gi 97.22% <91.80%> (-0.55%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit de5f65c into master Mar 17, 2026
8 checks passed
@fingolfin fingolfin deleted the codex/markdown-error-positions branch March 17, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant