Thin wrapper: delegate to game-ci/unity-engine-core - #111
Draft
frostebite wants to merge 3 commits into
Draft
Conversation
Delegates activation logic to the extracted implementation in game-ci/unity-engine-core instead of maintaining a local copy, per game-ci/roadmap#11 workstream 2 (Option A). src/model/* is removed; build/test coverage now lives in the destination repo.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
unity-engine-core#2 fixed a missing-dist bug (Yarn Berry doesn't run install-time scripts by default, so the git dependency had no compiled output). This repoints the lockfile at that fix.
unity-engine-core#3 fixed a real runtime bug: the compiled dist/ output was missing Dockerfile/entrypoint.sh (tsc doesn't copy static assets), so Docker.build() would have failed to find its Dockerfile the first time activation actually ran through this dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real consumer of game-ci/unity-engine-core (paired with unity-engine-core#1), implementing the "thin wrapper" direction settled on in game-ci/roadmap#11 (workstream 2, Option A) —
unity-activatewas the pilot repo chosen for extraction since it's the smallest of the three action repos (1 input, 0 outputs).What changed:
src/model/*(Action, Docker, ImageTag, Input + tests, ~467 lines) removed — this logic now lives ingame-ci/unity-engine-core'ssrc/unity-activate/, already extracted and tested there (21/21 tests passing).src/index.tsnow importsrunfrom@game-ci/unity-engine-core/dist/unity-activateand calls it directly.package.jsondepends on@game-ci/unity-engine-corevia a git dependency (not yet published to npm) pinned to#main.vitest.config.mts: addedpassWithNoTests: truesince coverage now lives in the destination repo.action.ymlis unchanged — stillmain: dist/index.js; the bundled output (viancc) now just contains the delegated implementation instead of a local copy. TheAction.rootFolder/actionFolder/dockerfilepath logic (unchanged, carried over verbatim during extraction) resolves relative to wherever the final bundle lands at runtime, sodist/Dockerfilein this repo is still the one that gets used.Open questions (draft, not final):
unity-engine-core'srun()export supports both in-process and subprocess invocation, so this isn't locked in. Feedback welcome on whether this is the right mechanism before repeating the pattern forunity-builder/unity-test-runner.#main.yarn installfor a git dependency'spreparescript needsenableScripts—.yarnrc.ymldoesn't currently set this explicitly; CI will confirm whether the default is sufficient or this needs an explicit flip.Typecheck passes locally (
tsc --noEmit, both repos); fullyarn install && yarn buildneeds to run in CI to validate the git-dependency install path end-to-end.