Skip to content

Fix: Accordion collapsed state background color not applying correctly #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
param-chandarana wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

Fix: Accordion collapsed state background color not applying correctly #3675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/block/accordion/frontend-accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class StackableAccordion {
}

el.classList[
! Array.from( el.classList ).includes( 'stk--is-open' ) ? 'add' : 'remove'
el.open ? 'add' : 'remove'
]( 'stk--is-open' )

// When the accordion is triggered to open/close, we animate
Expand Down
6 changes: 3 additions & 3 deletions src/components/block-css/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@ const BlockCss = props => {
// TODO: why do we have this condition for the collapsedSelector, but they just do the same prepending??
if ( hasCollapsed ) {
if ( generateForAllBlockStates ) {
collapsedSelector = prependClass( selector, '%h :where(.stk-block-accordion.stk--is-open) .%s' )
collapsedSelector = prependClass( selector, '%h :where(.stk-block-accordion:not(.stk--is-open)) .%s' )
} else if ( blockState === 'collapsed' ) {
collapsedSelector = prependClass( selector, ':where(.stk-block-accordion.stk--is-open) .%s' )
collapsedSelector = prependClass( selector, ':where(.stk-block-accordion:not(.stk--is-open)) .%s' )
} else {
collapsedSelector = prependClass( selector, ':where(.stk-block-accordion.stk--is-open) .%s' )
collapsedSelector = prependClass( selector, ':where(.stk-block-accordion:not(.stk--is-open)) .%s' )
}
}

Expand Down