-
Notifications
You must be signed in to change notification settings - Fork 67
feat (theme-compatibility): features can now inherit theme styles. #3052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prconcepcion
wants to merge
14
commits into
develop
Choose a base branch
from
fix/3035-theme
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
608541a
button and caption can inherit theme styles
0d730b7
fixed typo
3d3886f
Merge branch 'develop' into fix/3035-theme
f100be5
separated button and caption options
a4f08fb
Merge branch 'develop' into fix/3035-theme
d54e77b
Merge branch 'develop' into fix/3035-theme
1aeb2c2
fixed settings description
f0c1a15
fixed spacing
50630b6
changed description in admin settings
12cc264
refactored implementation
03dbfaa
Merge branch 'develop' into fix/3035-theme
aa70e56
added another class to exclude
8f71089
prevent style from being to theme styled buttons
f3d5697
added an extra class
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?php | ||
|
|
||
| // Exit if accessed directly. | ||
| if ( ! defined( 'ABSPATH' ) ) { | ||
| exit; | ||
| } | ||
|
|
||
| var_dump(get_option( 'stackable_inherit_styles_from_theme' )); | ||
|
prconcepcion marked this conversation as resolved.
Outdated
|
||
|
|
||
| if ( get_option( 'stackable_inherit_styles_from_theme' ) === '1' ) { | ||
|
|
||
| if ( ! function_exists( 'stackable_add_inherit_button_theme_class' ) ) { | ||
| function stackable_add_inherit_button_theme_class( $block_content, $block ) { | ||
| if ( ! class_exists( 'WP_HTML_Tag_Processor' ) ) { | ||
| return $block_content; | ||
| } | ||
|
|
||
| $html_tag = new WP_HTML_Tag_Processor( $block_content ); | ||
|
|
||
| while ( $html_tag->next_tag( 'a' ) ) { | ||
| $img_classname = $html_tag->get_attribute( 'class' ); | ||
|
|
||
| if ( strpos( $img_classname, 'stk-button') !== false ) { | ||
|
prconcepcion marked this conversation as resolved.
Outdated
|
||
| $html_tag->add_class( 'wp-element-button' ); | ||
| } | ||
| } | ||
|
|
||
| return $html_tag->get_updated_html(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| add_filter( 'render_block_stackable/button', 'stackable_add_inherit_button_theme_class', 1, 2 ); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| <?php | ||
|
|
||
| // Exit if accessed directly. | ||
| if ( ! defined( 'ABSPATH' ) ) { | ||
| exit; | ||
| } | ||
|
|
||
| if ( get_option( 'stackable_inherit_styles_from_theme' ) === '1' ) { | ||
|
|
||
| if ( ! function_exists( 'stackable_add_inherit_figcaption_theme_class' ) ) { | ||
| function stackable_add_inherit_figcaption_theme_class( $block_content, $block ) { | ||
| if ( ! class_exists( 'WP_HTML_Tag_Processor' ) ) { | ||
| return $block_content; | ||
| } | ||
|
|
||
| $html_tag = new WP_HTML_Tag_Processor( $block_content ); | ||
|
|
||
| while ( $html_tag->next_tag( 'figcaption' ) ) { | ||
| $img_classname = $html_tag->get_attribute( 'class' ); | ||
|
|
||
| if ( strpos( $img_classname, 'stk-img-figcaption') !== false ) { | ||
| $html_tag->add_class( 'wp-element-caption' ); | ||
| } | ||
| } | ||
|
|
||
| return $html_tag->get_updated_html(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| add_filter( 'render_block_stackable/image', 'stackable_add_inherit_figcaption_theme_class', 1, 2 ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks hard to read, split off to: