CI add visual regression tests - #672
Draft
kroq-gar78 wants to merge 2 commits into
Draft
Conversation
Previously the test only asserted a PNG got written; a rendering regression could only be caught by a human looking at it. Now it compares all twelve dataview renders (quickflat + headless WebGL) against stored references, with tolerances validated by injecting a real regression (R/B channel swap), and runs by default. Reference images are added in the next commit; a missing reference skips rather than fails, checked before rendering.
700 KiB of lossless WebP: the six dataview classes rendered via cortex.quickshow and cortex.export.plot_panels. Generated on main at 5af26a8 -- byte-identical to this branch's output, confirming the dataset restructure changed nothing about what gets drawn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the render test only asserted a PNG got written; a rendering regression could only be caught by a human looking at it. Now it compares all twelve dataview renders (quickflat + headless WebGL) against stored reference images, with tolerances validated by injecting a real regression (R/B channel swap), and runs by default.
References images (700 KiB, lossless WebP) were generated on main at 5af26a8 and are byte-identical to this branch's output.
Right now the reference images are prefixed with
qs_andwg_, but this can be changed to match the renderers' actual names.Test plan
pytest cortex/tests/test_webgl_headless.py