Warn instead of throwing validation-time errors#304
Open
cedar323 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
What changed
TypeContext.warn()now converts validation-time exceptions into warning messages instead of throwing.$Shape<T>invariant raised during validation setup.Why
warn: trueshould warn and return the original input instead of throwing. Some validation paths can fail before aValidationobject is returned, so the warning path needs to handle those exceptions too.Validation
node ..\..\node_modules\mocha\bin\mocha --require @babel/polyfill --require .\test-polyfill.js src\typed.test.js169 passing