fix: enforce implicit return assertion for non-empty function bodies#301
Open
ncthuc2004 wants to merge 1 commit into
Open
fix: enforce implicit return assertion for non-empty function bodies#301ncthuc2004 wants to merge 1 commit into
ncthuc2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
babel-plugin-flow-runtimereturn;is added when there is no explicitReturnStatementWhy
Issue #2 reports missing return assertions for implicit returns.
The current condition uses incorrect boolean precedence and fails to append
return;in non-empty bodies unless the last statement is explicitlyreturn.Validation
TEST_FILTER=2-implicit-function-return-with-bodynpx mocha --opts NUL --require @babel/polyfill --require ./test-polyfill.js src/__tests__/transform.test.js --timeout 100001 passingIssueHunt Summary
Referenced issues
This pull request has been submitted to: