fix(plugin): avoid undefined type parameter references when assert=false#296
Open
ncthuc2004 wants to merge 1 commit into
Open
fix(plugin): avoid undefined type parameter references when assert=false#296ncthuc2004 wants to merge 1 commit into
ncthuc2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert/warnchecks are disabled<X> let bar: Xunderassert:falsetransform modeWhy
With
assert:false, the plugin still emitted helper bindings likelet _barType = Xin function scope, butXwas only declared inside annotation wrappers. This caused runtimeX is undefinederrors.Closes #180
IssueHunt Summary
Referenced issues
This pull request has been submitted to: