Fix type parameter references when assertions are disabled#292
Open
sellimenes wants to merge 1 commit into
Open
Fix type parameter references when assertions are disabled#292sellimenes wants to merge 1 commit into
sellimenes wants to merge 1 commit into
Conversation
Open
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180.
Summary
t.annotate(... t.function(...))callback where those parameters are defined.let bar: Xwith assertions disabled.Tests
TEST_FILTER='bugs/180-type-parameter-assert-false' yarn --cwd packages/babel-plugin-flow-runtime testyarn --cwd packages/babel-plugin-flow-runtime testyarn --cwd packages/babel-plugin-flow-runtime lint(exits 0; existing repo-wide jsx-a11y rule warnings remain)git diff --check