Fix assert false type parameter variables#285
Open
dicnunz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180
IssueHunt bounty: https://issuehunt.io/repos/71611551/issues/180
What changed
let bar: Xand plugin optionassert: false.Why
With
assert: false, assignment checks are disabled too, so the generated_barType = Xtemporary is unused. In generic functions it can reference a type parameter outside the runtime scope and produce undefined output.Tested
TEST_FILTER='180-assert-false-type-parameter' yarn --cwd packages/babel-plugin-flow-runtime testyarn --cwd packages/flow-config-parser buildyarn --cwd packages/babel-plugin-flow-runtime buildyarn --cwd packages/babel-plugin-flow-runtime test(239 passing)yarn --cwd packages/babel-plugin-flow-runtime lint(exits 0; existing repo-wide jsx-a11y rule warnings only)git diff --checkNote: full root
yarn install --frozen-lockfilereaches dependency linking but fails while building an unrelated old docsnode-sassdependency because node-gyp expectspython/python2. I used a temporaryGIT_CONFIG_GLOBALrewrite for the oldgit://github.comdependency URL during install.IssueHunt Summary
Referenced issues
This pull request has been submitted to: