Skip to content

docs: require per-view SwiftUI models#114

Merged
gaelic-ghost merged 2 commits into
mainfrom
docs/swiftui-per-view-models
Jul 8, 2026
Merged

docs: require per-view SwiftUI models#114
gaelic-ghost merged 2 commits into
mainfrom
docs/swiftui-per-view-models

Conversation

@gaelic-ghost

Copy link
Copy Markdown
Owner

Summary

  • Require SwiftUI view models to be per-view only, with matching <ViewFileName>+Model.swift files and no shared view-cluster models.
  • Remove stale guidance that allowed a controller or model to own state for a view cluster.
  • Propagate the rule through Apple Dev Skills architecture guidance, source-structure guidance, shared snippets, older Swift snippets, and generated AGENTS templates.
  • Bump the shared Socket version to 8.5.5 for the patch release.

Verification

  • uv run pytest plugins/apple-dev-skills/tests/test_swiftui_app_architecture_workflow.py plugins/apple-dev-skills/tests/test_structure_swift_sources_workflow.py plugins/apple-dev-skills/tests/test_xcode_guidance_sync_workflow.py
  • plugins/apple-dev-skills/.github/scripts/sync_shared_snippets.sh --check
  • uv run scripts/validate_socket_metadata.py
  • Audit search confirmed stale allowed wording only remains as forbidden test strings.

Release

  • Mode: subtrees
  • plugins/apple-dev-skills: no subtree action; Socket is the canonical payload and the standalone repo is only the compatibility pointer.

@gaelic-ghost gaelic-ghost added the documentation Improvements or additions to documentation label Jul 8, 2026 — with ChatGPT Codex Connector
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@gaelic-ghost, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4584a34-3def-4d72-b30b-5b7015ad99fe

📥 Commits

Reviewing files that changed from the base of the PR and between afd93b5 and f6a1d15.

⛔ Files ignored due to path filters (8)
  • plugins/agent-portability-skills/uv.lock is excluded by !**/*.lock
  • plugins/apple-dev-skills/uv.lock is excluded by !**/*.lock
  • plugins/cardhop-app/mcp/uv.lock is excluded by !**/*.lock
  • plugins/productivity-skills/uv.lock is excluded by !**/*.lock
  • plugins/python-skills/uv.lock is excluded by !**/*.lock
  • plugins/things-app/mcp/uv.lock is excluded by !**/*.lock
  • plugins/things-app/uv.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (71)
  • plugins/agent-portability-skills/.codex-plugin/plugin.json
  • plugins/agent-portability-skills/pyproject.toml
  • plugins/agentdeck/.codex-plugin/plugin.json
  • plugins/android-dev-skills/.codex-plugin/plugin.json
  • plugins/apple-dev-skills/.codex-plugin/plugin.json
  • plugins/apple-dev-skills/pyproject.toml
  • plugins/apple-dev-skills/shared/agents-snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/appkit-app-architecture-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/apple-typography-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/apple-ui-accessibility-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/avaudio-engine-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/avfaudio-session-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/avfoundation-media-pipeline-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/bootstrap-swift-package/assets/AGENTS.md
  • plugins/apple-dev-skills/skills/bootstrap-swift-package/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/bootstrap-xcode-app-project/assets/AGENTS.md
  • plugins/apple-dev-skills/skills/bootstrap-xcode-app-project/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/bootstrap-xcode-app-project/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/core-animation-layer-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/coreaudio-modernization-repair-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/coremedia-timing-samplebuffer-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/devicecheck-app-attest-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/explore-apple-swift-docs/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/explore-apple-swift-docs/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/format-swift-sources/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/migrate-xcode-project-to-xcodegen/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/safari-extension-control-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/sf-symbols-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/structure-swift-sources/SKILL.md
  • plugins/apple-dev-skills/skills/structure-swift-sources/references/layout-rules.md
  • plugins/apple-dev-skills/skills/structure-swift-sources/references/source-organization-rules.md
  • plugins/apple-dev-skills/skills/swiftui-animation-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/swiftui-app-architecture-workflow/SKILL.md
  • plugins/apple-dev-skills/skills/swiftui-app-architecture-workflow/references/anti-patterns-and-corrections.md
  • plugins/apple-dev-skills/skills/swiftui-app-architecture-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/sync-xcode-project-guidance/assets/AGENTS.md
  • plugins/apple-dev-skills/skills/sync-xcode-project-guidance/assets/append-section.md
  • plugins/apple-dev-skills/skills/sync-xcode-project-guidance/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/xcode-app-project-workflow/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/xcode-app-project-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/xcode-build-run-workflow/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/xcode-build-run-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/xcode-coding-intelligence-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/skills/xcode-testing-workflow/references/snippets/apple-swift-core.md
  • plugins/apple-dev-skills/skills/xcode-testing-workflow/references/snippets/apple-xcode-project-core.md
  • plugins/apple-dev-skills/tests/test_structure_swift_sources_workflow.py
  • plugins/apple-dev-skills/tests/test_swiftui_app_architecture_workflow.py
  • plugins/apple-dev-skills/tests/test_xcode_guidance_sync_workflow.py
  • plugins/cardhop-app/.codex-plugin/plugin.json
  • plugins/cardhop-app/mcp/pyproject.toml
  • plugins/cloud-deployment-skills/.codex-plugin/plugin.json
  • plugins/cloud-inference-skills/.codex-plugin/plugin.json
  • plugins/dotnet-skills/.codex-plugin/plugin.json
  • plugins/game-dev-skills/.codex-plugin/plugin.json
  • plugins/network-protocol-skills/.codex-plugin/plugin.json
  • plugins/productivity-skills/.codex-plugin/plugin.json
  • plugins/productivity-skills/pyproject.toml
  • plugins/python-skills/.codex-plugin/plugin.json
  • plugins/python-skills/pyproject.toml
  • plugins/reverse-engineering-skills/.codex-plugin/plugin.json
  • plugins/rust-skills/.codex-plugin/plugin.json
  • plugins/server-side-jvm/.codex-plugin/plugin.json
  • plugins/server-side-swift/.codex-plugin/plugin.json
  • plugins/spotify/.codex-plugin/plugin.json
  • plugins/swift-lang/.codex-plugin/plugin.json
  • plugins/swiftasb-skills/.codex-plugin/plugin.json
  • plugins/things-app/.codex-plugin/plugin.json
  • plugins/things-app/mcp/pyproject.toml
  • plugins/things-app/pyproject.toml
  • plugins/web-dev-skills/.codex-plugin/plugin.json
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/swiftui-per-view-models

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gaelic-ghost gaelic-ghost merged commit b7a4800 into main Jul 8, 2026
2 checks passed
@gaelic-ghost gaelic-ghost deleted the docs/swiftui-per-view-models branch July 8, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant