docs: enforce strict XcodeGen roots#111
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (69)
📝 WalkthroughWalkthroughThis PR bumps the version string from 8.5.1 to 8.5.2 across numerous plugin.json and pyproject.toml files, and separately overhauls Apple Xcode/XcodeGen project-structure guidance: a single app lifecycle entry point rule and revised broad-top-level syncedFolder source-root rules are propagated across a shared snippet, per-skill snippet copies, workflow docs, a migration audit script, a project template, and tests. ChangesPlugin/package version bumps
Apple Xcode/XcodeGen project-structure guidance overhaul
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)Not applicable — the changes are primarily documentation guidance edits and a script/audit logic update within a single tool, without multi-component request/response flows. Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33dfe0a466
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| + ", ".join(project_yml_audit["fragmented_source_entries"]) | ||
| + ". Use one Sources entry for the app target, one Tests entry for the test target, and one entry per separate top-level logical root only." | ||
| ) | ||
| if len(file_audit["app_entry_points"]) > 1: |
There was a problem hiding this comment.
In projects with more than one native target under Sources (for example a main app plus a helper/widget app, each with its own @main), file_audit["app_entry_points"] is a repo-wide list, so this condition recommends collapsing valid per-target entry points into a single app target entry point. That audit output can lead the migration workflow to remove required launch boundaries; the check should use target/source membership, or at least only compare entry points within the same app target, before flagging.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by CodeRabbit