jpass- Adds user-selected language feature by octavo-dev · Pull Request #32 · gaborbata/jpass

octavo-dev · 2024-03-10T02:30:27Z

This PR introduces:

Updates GUI when user selects a language
Stores the language selected in jpass.properties file
Sets JFileChooser CANCEL button based on language selected
Updates README.md file
Adds UTs to increase code coverage

…cted

src/main/java/jpass/ui/JPassFrame.java

src/main/resources/resources/languages/languages_hu_HU.properties

src/main/resources/resources/languages/languages_it_IT.properties

src/main/java/jpass/util/Configuration.java

src/main/java/jpass/ui/JPassFrame.java

gaborbata · 2024-03-10T06:52:49Z

Thanks for your changes, I'll review them in the following weeks (depending on job activities).

src/main/resources/resources/languages/languages_it_IT.properties

gaborbata · 2024-03-18T12:32:26Z

src/main/java/jpass/ui/JPassFrame.java

        if (instance == null) {
-            String languageTag = Configuration.getInstance().get("language.languageSetting", "en-US");
-            instance = new JPassFrame(fileName, Locale.forLanguageTag(languageTag));
+            String languageTag = Configuration.getInstance().get(LANGUAGE_LANGUAGE_SETTING, null);


Why don't you simply use Configuration.getInstance().get(LANGUAGE_LANGUAGE_SETTING, "en-US") here?

gaborbata · 2024-03-18T12:39:47Z

src/main/resources/resources/languages/languages_en_US.properties

 panel.unencryptedDataWarningMessage=Please note that all data will be stored unencrypted.\nMake sure you keep the exported file in a secure location.
+
+language.languageChanged=Language has changed successfully.
+language.en.us=English


I don't think it is a good idea to store language names in language resources. Every time a new translation in introduced, then all the resources need to be updated. Maybe it would be better to hard-code them in the supported languages map.

I added them on the language resource because language names change on each language so they have to be actually translated. It's true that with every new language all the current languages resources needs to add this new language name but I believe it's expected.

Let me know if you want it to change it anyway.

…cted

…o user_selected

octavo-dev added 12 commits March 5, 2024 14:56

Initial commit

e70ea23

Adding supported languages dinamically

ed274b7

Adding constants and first working version

dede15d

Adds refresh method

5c9e9d0

Sets en-US as default

411b4e1

Updates GUI when user selects a language

9583a46

Sets new icon. Sets JFileChooser CANCEL button based on language sele…

7deb07e

…cted

Updates README.md

2b82846

Completes user-selected language implementation

b3c5f7b

Localizes language.languageChanged string

4042ed8

Adds UT for language

d811540

Adds UTs for increasing Jacoco Coverage

7a668d6