Skip to content

Update OpenAPI schema#12

Merged
masaya-osuga merged 7 commits intomainfrom
update-openapi-schema
Mar 18, 2026
Merged

Update OpenAPI schema#12
masaya-osuga merged 7 commits intomainfrom
update-openapi-schema

Conversation

@dotto-api-schema-updater
Copy link
Copy Markdown
Contributor

This PR updates the OpenAPI schema from dotto-typespec.

Triggered by: fun-dotto/dotto-typespec@992af91

@masaya-osuga masaya-osuga marked this pull request as ready for review March 18, 2026 13:29
@masaya-osuga masaya-osuga self-assigned this Mar 18, 2026
Copy link
Copy Markdown
Contributor

@hikaru-0602 hikaru-0602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s OpenAPI schema (and regenerated Go server/client types) to match the latest dotto-typespec, expanding the API surface from “Subject Service” to a broader “Academic Service”.

Changes:

  • Updated openapi/openapi.yaml with new resources/endpoints (faculties, rooms, reservations, course registrations, timetable items) and schema adjustments.
  • Regenerated generated/api.gen.go to include new models, routes, params, and strict handler interfaces/wrappers.
  • Added new handler method stubs in internal/handler/* and updated converter.go for schema changes (SubjectFaculty + dsopSubject).

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 19 comments.

Show a summary per file
File Description
openapi/openapi.yaml Adds new endpoints/schemas and updates service metadata/servers.
generated/api.gen.go Regenerated OpenAPI bindings for new endpoints/models (Gin + strict wrappers).
internal/handler/converter.go Updates domain→API conversions to match updated schemas.
internal/handler/course_registration_list.go Adds stub handler for new CourseRegistrations list endpoint.
internal/handler/course_registration_create.go Adds stub handler for new CourseRegistrations create endpoint.
internal/handler/course_registration_delete.go Adds stub handler for new CourseRegistrations delete endpoint.
internal/handler/faculty_list.go Adds stub handler for new Faculties list endpoint.
internal/handler/faculty_create.go Adds stub handler for new Faculties create endpoint.
internal/handler/faculty_delete.go Adds stub handler for new Faculties delete endpoint.
internal/handler/faculty_detail.go Adds stub handler for new Faculties detail endpoint.
internal/handler/faculty_update.go Adds stub handler for new Faculties update endpoint.
internal/handler/room_list.go Adds stub handler for new Rooms list endpoint.
internal/handler/room_create.go Adds stub handler for new Rooms create endpoint.
internal/handler/room_delete.go Adds stub handler for new Rooms delete endpoint.
internal/handler/room_detail.go Adds stub handler for new Rooms detail endpoint.
internal/handler/room_update.go Adds stub handler for new Rooms update endpoint.
internal/handler/reservation_list.go Adds stub handler for new Reservations list endpoint.
internal/handler/timetable_item_list.go Adds stub handler for new TimetableItems list endpoint.
internal/handler/timetable_item_create.go Adds stub handler for new TimetableItems create endpoint.
internal/handler/timetable_item_delete.go Adds stub handler for new TimetableItems delete endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread internal/handler/faculty_delete.go
Comment thread internal/handler/faculty_update.go
Comment thread internal/handler/room_delete.go
Comment thread internal/handler/reservation_list.go
Comment thread internal/handler/timetable_item_list.go
Comment thread internal/handler/faculty_create.go
Comment thread internal/handler/course_registration_list.go
Comment thread internal/handler/room_list.go
Comment thread internal/handler/room_update.go
Comment thread internal/handler/timetable_item_delete.go
@masaya-osuga masaya-osuga merged commit 923467d into main Mar 18, 2026
1 check passed
@masaya-osuga masaya-osuga deleted the update-openapi-schema branch March 18, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants