Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s OpenAPI schema (and regenerated Go server/client types) to match the latest dotto-typespec, expanding the API surface from “Subject Service” to a broader “Academic Service”.
Changes:
- Updated
openapi/openapi.yamlwith new resources/endpoints (faculties, rooms, reservations, course registrations, timetable items) and schema adjustments. - Regenerated
generated/api.gen.goto include new models, routes, params, and strict handler interfaces/wrappers. - Added new handler method stubs in
internal/handler/*and updatedconverter.gofor schema changes (SubjectFaculty+dsopSubject).
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| openapi/openapi.yaml | Adds new endpoints/schemas and updates service metadata/servers. |
| generated/api.gen.go | Regenerated OpenAPI bindings for new endpoints/models (Gin + strict wrappers). |
| internal/handler/converter.go | Updates domain→API conversions to match updated schemas. |
| internal/handler/course_registration_list.go | Adds stub handler for new CourseRegistrations list endpoint. |
| internal/handler/course_registration_create.go | Adds stub handler for new CourseRegistrations create endpoint. |
| internal/handler/course_registration_delete.go | Adds stub handler for new CourseRegistrations delete endpoint. |
| internal/handler/faculty_list.go | Adds stub handler for new Faculties list endpoint. |
| internal/handler/faculty_create.go | Adds stub handler for new Faculties create endpoint. |
| internal/handler/faculty_delete.go | Adds stub handler for new Faculties delete endpoint. |
| internal/handler/faculty_detail.go | Adds stub handler for new Faculties detail endpoint. |
| internal/handler/faculty_update.go | Adds stub handler for new Faculties update endpoint. |
| internal/handler/room_list.go | Adds stub handler for new Rooms list endpoint. |
| internal/handler/room_create.go | Adds stub handler for new Rooms create endpoint. |
| internal/handler/room_delete.go | Adds stub handler for new Rooms delete endpoint. |
| internal/handler/room_detail.go | Adds stub handler for new Rooms detail endpoint. |
| internal/handler/room_update.go | Adds stub handler for new Rooms update endpoint. |
| internal/handler/reservation_list.go | Adds stub handler for new Reservations list endpoint. |
| internal/handler/timetable_item_list.go | Adds stub handler for new TimetableItems list endpoint. |
| internal/handler/timetable_item_create.go | Adds stub handler for new TimetableItems create endpoint. |
| internal/handler/timetable_item_delete.go | Adds stub handler for new TimetableItems delete endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@992af91