Add async support for HNS methods#756
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 75.45% 75.77% +0.31%
==========================================
Files 19 19
Lines 2885 2889 +4
==========================================
+ Hits 2177 2189 +12
+ Misses 708 700 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/gcbrun |
| assert f2 in out | ||
|
|
||
|
|
||
| @pytest.mark.asyncio |
There was a problem hiding this comment.
Since we should already have find(), info() related sync tests in test_core.py, adding more async tests for same functionality might be maintenance hassle, are they adding any specific value ?
There was a problem hiding this comment.
This test file is specifically for verifying all the methods under async context, the tests in test_core.py and other integration tests are running in sync context.
These tests are not primarily for verifying functionality but more focused on invoking from async context and hence added only a basic test for each method.
There was a problem hiding this comment.
Lets add this intent as documentation on the test_async_gcsfs file as well
mv method calls copy internally and sets on_error to true. Earlier onerror is set instead of on_error and hence it was getting ignored. copy method uses rewrite API which works for objects and not on folders or prefixes. So when mv is called on directory path, copy method would throw error. Currently the sync mv method in spec.py is also setting the wrong paramter onerror instead of on_error and hence this issue is not noticed.
|
/gcbrun |
|
/gcbrun |
As we are temporarily not passing on_error parameter, we can move the _mv to the GCSFileSystem as it is consistent with sync mv method.
|
/gcbrun |
3 participants
Uh oh!
There was an error while loading. Please reload this page.