Extended type hint of credential field#534
Merged
kyleknap merged 7 commits intofsspec:mainfrom Feb 25, 2026
Merged
Conversation
nateprewitt
suggested changes
Feb 18, 2026
Collaborator
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
This looks great, @wonwuakpa-msft! One minor change we can make before we merge, with 72995ba, we now have PEP 563 annotations that automatically support forward references. We shouldn't need the quoting anymore.
nateprewitt
reviewed
Feb 23, 2026
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
nateprewitt
approved these changes
Feb 24, 2026
Collaborator
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Thanks @wonwuakpa-msft! @kyleknap this should be set unless you have other comments. I'll rebase the other work once this is in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extended type hint of credential field.
Included new import (
annotations from __future__) to fix F821 linting error of undefined name in type hintType of Change