[Repo Assist] test: add unit tests for JsonValue.ParseMultiple and JsonValue.Load#1734
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
- ParseMultiple (NDJSON): 6 tests covering empty string, single value, newline-delimited JSON, whitespace-separated values, mixed types, and lazy evaluation guarantee - JsonValue.Load(Stream): 2 tests (basic object, nested structure) - JsonValue.Load(TextReader): 1 test (array content) - JsonValue.WriteTo: 2 tests (DisableFormatting compact output, None/default indented output) All 2920 tests pass (11 new tests; up from 2909). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
JsonValue.ParseMultiple,JsonValue.Load(Stream),JsonValue.Load(TextReader), andJsonValue.WriteTohad no direct unit tests. This PR adds 11 tests covering these methods.Motivation
ParseMultipleis the primary API for parsing NDJSON (newline-delimited JSON), a format used widely in log streaming and data pipelines. It had zero test coverage.Load(Stream)/Load(TextReader)are convenience IO methods used in real applications; verifying their behaviour directly (not just through the type provider) is valuable.WriteToserialisation options (None/DisableFormatting) were tested indirectly viaToString()but not via theWriteTopath directly.New Tests
ParseMultiple(NDJSON / concatenated JSON)JsonValue.Load(Stream)/Load(TextReader)MemoryStreamMemoryStreamStringReader(asTextReader)JsonValue.WriteToDisableFormattingproduces compact{"a":1,"b":"x"}outputNoneproduces indented output with newlines and spacesTest Status
dotnet test tests/FSharp.Data.Core.Tests/— 2920 passed, 0 failed (up from 2909; 11 new tests)