Skip to content

Revert "Revert "Horrible fix for cross site badness""#506

Open
georgelgeback wants to merge 1 commit intomainfrom
revert-503-revert-501-fix-cross-site
Open

Revert "Revert "Horrible fix for cross site badness""#506
georgelgeback wants to merge 1 commit intomainfrom
revert-503-revert-501-fix-cross-site

Conversation

@georgelgeback
Copy link
Copy Markdown
Contributor

Reverts #503

Reason: I pushed the current solution to stage, tested it and it did not work.
If any other solution can be found that would be great. I also strongly dislike this fix.

@HellFelix
Copy link
Copy Markdown
Contributor

I’m confused, do you want to revert the reverted fix? I thought the regex fix was ok?

@maffe03
Copy link
Copy Markdown
Member

maffe03 commented Apr 2, 2026

I'm gonna take a guess and say that its because you can't put in a list and a regex? Haven't tried the code though so idk

@georgelgeback
Copy link
Copy Markdown
Contributor Author

georgelgeback commented Apr 2, 2026

I'm not sure why but I know trying to run the frontend against the stage backend with the regex did not work. Best explanation I have is that regex is treated in the same way as the wildcard and doesn't change how cookies are allowed.

@HellFelix
Copy link
Copy Markdown
Contributor

Does it work locally? The problem was with localhost CORS, no?

@georgelgeback
Copy link
Copy Markdown
Contributor Author

Backend was on stage, frontend was local when I tested. This is the only setup where it didn't work and we wanted it to.

@HellFelix
Copy link
Copy Markdown
Contributor

I still think this solution is unsatisfying, and I think we should eventually try to use regex, but if we really need this now, I’ll approve on the condition that the the issue remains open

@georgelgeback
Copy link
Copy Markdown
Contributor Author

We don't super need this now, we can wait a few weeks until we figure out a good solution.

Copy link
Copy Markdown
Contributor

@HellFelix HellFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the condition that this is fixed later!

@HellFelix
Copy link
Copy Markdown
Contributor

Your call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants