Skip to content

Fix timeout and listener leaks in readResponseById #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frouaix merged 2 commits into from
Feb 22, 2026
Merged

Fix timeout and listener leaks in readResponseById #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b21fcc
Initial plan
Copilot Feb 22, 2026
cb28ba6
Fix readResponseById: clear timeout on success, remove handler on tim…
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/mcp-server/test/integration/e2e-apps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function readResponseById(proc: ChildProcess, id: number, timeoutMs = 15000): Pr
const msg = JSON.parse(line) as Record<string, unknown>;
if (msg["id"] === id) {
proc.stdout!.off("data", handler);
clearTimeout(timer);
resolve(msg);
return;
}
Expand All @@ -52,7 +53,11 @@ function readResponseById(proc: ChildProcess, id: number, timeoutMs = 15000): Pr
}
};
proc.stdout!.on("data", handler);
setTimeout(() => reject(new Error(`Timeout waiting for response id=${id}`)), timeoutMs);
const timer = setTimeout(() => {
proc.stdout!.off("data", handler);
reject(new Error(`Timeout waiting for response id=${id}`));
}, timeoutMs);
timer.unref();
Comment on lines 46 to +60
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same timeout and listener leak issues fixed here also exist in packages/mcp-server/test/integration/server.test.ts. That file has two similar functions (readResponse on line 14 and readResponseById on line 38) that also need:

  1. The timer handle captured and cleared on success
  2. The handler removed on timeout
  3. The timer unref'd to prevent blocking event loop exit

Consider applying the same fix pattern to those functions as well.

Copilot uses AI. Check for mistakes.
});
}

Expand Down