Skip to content

docs: brainstorm and plan the failed-then-fixed capture trigger#3567

Closed
marcusrbrown wants to merge 1 commit into
mainfrom
docs/c2-failed-then-fixed-plan
Closed

docs: brainstorm and plan the failed-then-fixed capture trigger#3567
marcusrbrown wants to merge 1 commit into
mainfrom
docs/c2-failed-then-fixed-plan

Conversation

@marcusrbrown

Copy link
Copy Markdown
Collaborator

Scopes and plans the second learning-capture trigger: merged PRs whose CI failed then passed before merge feed the existing propose-only pipeline.

Key decisions

  • Transition detection is one GraphQL query per PR (per-commit per-check conclusions across the PR's SHA history) — cheap and proven, no new dependency.
  • The fixing diff is the primary signal, always available; the failing-log excerpt is best-effort and degrades to a placeholder when logs are purged.
  • A new secret/redaction scan layers on the existing private-repo-name gate, because CI logs and diffs leak more than repo names (PATs, keys, internal hostnames, paths). It blocks on hard secrets and redacts paths/hostnames before anything reaches the agent.
  • A discriminated candidate union lets both triggers share dedup, the per-run cap, and the privacy gate — one proposal per merge SHA regardless of how many triggers a PR matches.

Standard plan, four dependency-ordered units (secret scan → candidate union → CI-fix harvester → workflow/prompt wiring). The accepted value-gate risk (corpus adoption not yet measured) is recorded in the requirements doc.

Add the second capture trigger: PRs whose CI failed then passed before merge feed
the existing propose-only pipeline. Transition detection is one GraphQL query per
PR; the fixing diff is the primary signal with best-effort failing logs; a new
secret/redaction scan layers on the private-name gate because logs and diffs leak
more than repo names; a discriminated candidate union keeps dedup, cap, and
privacy shared across both triggers.
@marcusrbrown marcusrbrown requested a review from fro-bot as a code owner June 23, 2026 21:37
@marcusrbrown marcusrbrown deleted the docs/c2-failed-then-fixed-plan branch June 23, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants