Add steam boiler pool#1399
Draft
simonvoelcker wants to merge 3 commits into
Draft
Conversation
github-actions
Bot
added
part:docs
simonvoelcker
force-pushed
the
steam-boiler-pool
branch
2 times, most recently
from
3c11c7f to
8d9d1fe
Compare
simonvoelcker
requested review from
ela-kotulska-frequenz
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR introduces a new SteamBoilerPool timeseries package intended to provide a pool abstraction (similar to existing component pools) for observing and controlling steam boiler components, and updates dependencies/release notes accordingly.
Changes:
- Added a new
timeseries.steam_boiler_poolpackage withSteamBoilerPool, reference store, and report protocol types. - Updated
pyproject.tomldependency minimums forfrequenz-client-microgridandfrequenz-microgrid-component-graph. - Added a release note entry announcing
SteamBoilerPool.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/frequenz/sdk/timeseries/steam_boiler_pool/_steam_boiler_pool.py |
Adds the SteamBoilerPool wrapper and exposes a total-power Formula. |
src/frequenz/sdk/timeseries/steam_boiler_pool/_steam_boiler_pool_reference_store.py |
Adds the reference store for shared formula/bounds tracking state (currently incomplete). |
src/frequenz/sdk/timeseries/steam_boiler_pool/_result_types.py |
Adds the SteamBoilerPoolReport protocol for power status reporting. |
src/frequenz/sdk/timeseries/steam_boiler_pool/__init__.py |
Exposes public symbols for the new steam boiler pool package. |
RELEASE_NOTES.md |
Announces the new SteamBoilerPool feature. |
pyproject.toml |
Bumps dependency constraints needed for the new pool/formula support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @override | ||
| def create_bounds_tracker(self) -> None: | ||
| """Create the bounds tracker for the pool.""" |
Contributor
Author
There was a problem hiding this comment.
@llucax @shsms do we need a bounds tracker for steam boilers? Asking because I don't know what bounds trackers are used for at the moment, and also because the existing ones use dataclasses from this module that openly states it should be removed in the near future. Can either of you shine some light on this?
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
simonvoelcker
force-pushed
the
steam-boiler-pool
branch
from
2fc1002 to
9d37987
Compare
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
simonvoelcker
force-pushed
the
steam-boiler-pool
branch
from
9d37987 to
b372784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.