Open
Conversation
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
These tests should ideally use custom formulas and not depend on the formula generator, but that's a bigger change because that would affect most of the tests in this repo. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
requested review from
ela-kotulska-frequenz
and removed request for
a team
github-actions
bot
added
part:tests
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generation and evaluation of the formulas are now implemented and tested separately. So here we only need to test we are calling the correct formulas.