Fix typos and mentions to PyPI in CONTRIBUTING.md#584
Open
llucax wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
the
part:template
The `pytest` instructions sometimes use `test/` as the test directory but that's wrong, it should be `tests/` instead. Also update golden tests, and add a migration step to the migration script. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Private repos don't publish packages to PyPI, so we should not mention it in the `CONTRIBUTING.md` file. Also update golden tests, and add a migration step to the migration script. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
contributing-fixes
branch
from
74d6ddc to
8fb864b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pytestinstructions sometimes usetest/as the test directory but that's wrong, it should betests/instead. Also private repos don't publish packages to PyPI, so we should not mention it in theCONTRIBUTING.mdfile.This PR fixes both issues, and add migration steps to the migration script to fix it in existing projects.