Make key the canonical parameter, deprecate auth_key
#240
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse the previous rename: `key` is now the canonical parameter name in Dispatcher.__init__(). `auth_key` remains supported but emits a deprecation warning. Docstring examples updated to use `key` and `DISPATCH_API_KEY`. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
requested review from
stefan-brus-frequenz
and removed request for
a team
github-actions
bot
added
the
part:dispatcher
Contributor
|
I would hold on this, but it looks like we are moving towards removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses the previous rename so that
keyis the canonical parameter name inDispatcher.__init__().auth_keyremains supported but emits a deprecation warningkeyandDISPATCH_API_KEY