Remove obsolete type TargetComponents#167
Merged
Marenz merged 1 commit intofrequenz-floss:v0.x.xfrom Jun 25, 2025
Merged
Conversation
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete local TargetComponents alias and conversion helper from the actor dispatcher, switches to using the upstream TargetComponents type, updates tests accordingly, and cleans up exports and release notes.
- Drop
_convert_target_componentsand localTargetComponentsin_actor_dispatcher.py - Update tests to assert on the new
TargetComponentsdirectly - Remove
TargetComponentsexport in__init__.pyand document removal in release notes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_managing_actor.py | Updated assertions to use the new target type and removed old import |
| src/frequenz/dispatch/_actor_dispatcher.py | Removed conversion helper and alias; import upstream TargetComponents |
| src/frequenz/dispatch/init.py | Removed legacy TargetComponents from public API exports |
| RELEASE_NOTES.md | Documented removal of TargetComponents (with typos) |
Comments suppressed due to low confidence (2)
tests/test_managing_actor.py:180
- The test references an undefined symbol
TargetIds. Did you mean to importTargetComponentsor use the correct upstream type? Update the import or assertion to use the properTargetComponentsalias.
assert event.components == TargetIds(
RELEASE_NOTES.md:9
- There are typos here:
disptachshould bedispatchandtyeshould betype.
The `frequenz.disptach.TargetComponents` tye was removed, use `frequenz.client.dispatch.TargetComponents` instead.
shsms
approved these changes
Jun 25, 2025
ela-kotulska-frequenz
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.