Fixed that dispatches are never retried, but forever logged.#162
Fixed that dispatches are never retried, but forever logged.#162Marenz merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
github-actions
bot
added
part:docs
ela-kotulska-frequenz
left a comment
ela-kotulska-frequenz
left a comment
There was a problem hiding this comment.
LGTM just one comment
| if not dispatch.started: | ||
| _logger.info( | ||
| "Giving up on dispatch %s, duration was exceeded.", | ||
| dispatch.id, | ||
| ) |
There was a problem hiding this comment.
What duration?
From the code you try once, there is no duration. But maybe I don't see something?
Marenz
force-pushed
the
fix_forever_retrying
branch
from
15163ec to
597c18f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where failed dispatches were never retried and instead caused an infinite logging loop.
Key changes:
- Removed the
FailedDispatchesRetrierin favor of aTimer-based retry loop. - Introduced a
pending_dispatchesmap to track and retry failed dispatches. - Updated the main loop to trigger retries on timer events and cleaned up retry state in
_handle_dispatch.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frequenz/dispatch/_actor_dispatcher.py | Replaced retrier class with Timer, added pending_dispatches, updated retry flow. |
| RELEASE_NOTES.md | Updated bug-fix entry to describe the retry fix. |
Comments suppressed due to low confidence (2)
src/frequenz/dispatch/_actor_dispatcher.py:176
- [nitpick] The description of
retry_intervalis vague and still refers to "actors". Update it to clarify that this interval controls how often failed dispatches are retried via the timer.
retry_interval: How long to wait until trying to start failed actors again.
src/frequenz/dispatch/_actor_dispatcher.py:187
- [nitpick] The new retry logic around
pending_dispatchesand the timer-based loop lacks direct unit tests. Consider adding tests that simulate a dispatch failure and verify it gets retried after the configured interval and removed frompending_dispatches.
self._pending_dispatches: dict[int, Dispatch] = {}
597c18f to
d973fb6
Compare
ela-kotulska-frequenz
left a comment
ela-kotulska-frequenz
left a comment
There was a problem hiding this comment.
Is it possible that you retry dispatch that just started?
Is that correct approach?
| keys = list(self._pending_dispatches.keys()) | ||
| for identity in keys: | ||
| dispatch = self._pending_dispatches[identity] |
There was a problem hiding this comment.
Could you please remove dispatch from self._pending_dispatches here, not in self._handle_dispatch.
- It will be easier to read and more straightforward
- Removing dispatch from
_pending_dispatches, at the beginning of method calledhandle_dispatchis confusing :D
There was a problem hiding this comment.
I can also remove it here, but it is part of the design that handle dispatch removes it because if an updated dispatch instruction comes in, we need to erase the old pending one to not try to repeat with old outdated dispatches
Yes of course, I want to only retry dispatches that started. |
| self._actors: dict[int, ActorDispatcher.ActorAndChannel] = {} | ||
|
|
||
| self._retrier = ActorDispatcher.FailedDispatchesRetrier(retry_interval) | ||
| self._pending_dispatches: dict[int, Dispatch] = {} |
There was a problem hiding this comment.
Oww I god it!
Than Maybe rename it to _failed_dispatches? pending feels like they just started and didn't finished, yet.
Marenz
force-pushed
the
fix_forever_retrying
branch
from
d973fb6 to
28211d7
Compare
| ``` | ||
| """ | ||
|
|
||
| class FailedDispatchesRetrier(BackgroundService): |
There was a problem hiding this comment.
So satisfying to see this class go away... 🤣
| Args: | ||
| dispatch: The dispatch to handle. | ||
| """ | ||
| identity = self._dispatch_identity(dispatch) |
There was a problem hiding this comment.
Maybe it would be good to put a comment here about what you replied to Ela (or in the docstring), I agree at first sight it might look not super obvious wht removing dispatches from the pending list here.
Marenz
force-pushed
the
fix_forever_retrying
branch
2 times, most recently
from
31805be to
1532d1c
Compare
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
fix_forever_retrying
branch
from
1532d1c to
4894cfc
Compare
3 participants
No description provided.