Update dispatch api client#149
Merged
Marenz merged 1 commit intofrequenz-floss:v0.x.xfrom May 14, 2025
Merged
Conversation
github-actions
bot
added
part:tests
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dispatch API client to use the new DispatchApiClient in order to support the official TLS domains. The changes involve replacing the legacy Client with DispatchApiClient across the codebase, updating the dependency version in pyproject.toml, and revising release notes accordingly.
- Replaced Client with DispatchApiClient in tests and source files.
- Updated the dependency version for frequenz-client-dispatch.
- Revised release notes to reflect the new dispatch service URLs.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_managing_actor.py | Updated patch target from Client to DispatchApiClient; comment still refers to Client. |
| src/frequenz/dispatch/_dispatcher.py | Replaced Client usage with DispatchApiClient and updated corresponding inline comments. |
| src/frequenz/dispatch/_bg_service.py | Replaced Client with DispatchApiClient in the constructor and type annotations. |
| pyproject.toml | Updated dependency version for frequenz-client-dispatch. |
| RELEASE_NOTES.md | Revised release notes to announce the breaking change and new TLS endpoints. |
Comments suppressed due to low confidence (1)
tests/test_managing_actor.py:335
- Update this comment to refer to 'DispatchApiClient' instead of 'Client' to reflect the current patch target and avoid confusion.
# Patch `Client` class in Dispatcher with MyFakeClient
To support to use the official TLS domains, once setup Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
llucax
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support to use the official TLS domains, once setup