Expose src Dispatch for rare complex scenarios#131
Merged
Marenz merged 2 commits intofrequenz-floss:v0.x.xfrom Apr 3, 2025
Merged
Expose src Dispatch for rare complex scenarios#131Marenz merged 2 commits intofrequenz-floss:v0.x.xfrom
Marenz merged 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the source Dispatch for complex scenarios by adding a new _src field to DispatchInfo and updating the related actor dispatcher code.
- Updated DispatchInfo documentation with the new _src field.
- Modified the actor dispatcher to pass the dispatch as _src.
- Updated release notes to document the new feature.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/dispatch/_actor_dispatcher.py | Adds _src to DispatchInfo and updates documentation in _start_actor. |
| RELEASE_NOTES.md | Updates release notes to include the new _src feature. |
github-actions
bot
added
part:docs
shsms
approved these changes
Apr 2, 2025
llucax
approved these changes
Apr 3, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
LGTM as a temporary hack to unblock other work, but I think we need to find a better solution for the long term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DispatchInfo._srcfor when requiring more context