Revert "Make CODEOWNERS more specific"#241
Merged
Marenz merged 1 commit intofrequenz-floss:v1.x.xfrom Nov 12, 2025
Merged
Conversation
github-actions
bot
added
part:tooling
This reverts commit 95082b6. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CODEOWNERS file to simplify the ownership pattern by replacing a specific directory-based rule with a wildcard pattern that covers all files in the repository.
Key Changes:
- Changed the ownership pattern from specific directories (
/{src,tests,docs,dist}/) to a universal wildcard (*) pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # These are the default owners for everything in the repo, unless a later match | ||
| # takes precedence. | ||
| /{src,tests,docs,dist}/ @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team | ||
| * @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team |
There was a problem hiding this comment.
The wildcard pattern * only matches files in the root directory, not files in subdirectories. To match all files recursively throughout the repository, use ** or */** instead. If the intention is to maintain the previous behavior of covering src, tests, docs, and dist directories, the current pattern will not achieve this.
Suggested change
| * @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team | |
| ** @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 95082b6.
We decided to instead make the CODEOWNERS not required for approval