Make CODEOWNERS more specific#240
Conversation
That way dependabot PRs will be auto-merged as no owners are required for the pyproject.toml file. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
github-actions
bot
added
part:tooling
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the CODEOWNERS file to restrict ownership scope from the entire repository to specific directories only.
- Changed the default owner pattern from
*(all files) to explicit directory paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # These are the default owners for everything in the repo, unless a later match | ||
| # takes precedence. | ||
| * @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team | ||
| /{src,tests,docs,dist}/ @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team |
There was a problem hiding this comment.
The new ownership pattern only covers specific directories, leaving other repository files (e.g., configuration files, CI/CD workflows, root-level files) without explicit owners. This means changes to critical files like .github/workflows/*, pyproject.toml, or this CODEOWNERS file itself won't require review from the specified teams. Consider whether this is intentional or if a fallback pattern like * @frequenz-floss/api-dispatch-team should remain.
| /{src,tests,docs,dist}/ @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team | |
| /{src,tests,docs,dist}/ @frequenz-floss/api-dispatch-team @frequenz-floss/python-sdk-team | |
| # Global fallback owner for all other files. | |
| * @frequenz-floss/api-dispatch-team |
|
I guess we are reverting this and disabling the requirement for code owner approvals to merge, right? |
2 participants
That way dependabot PRs will be auto-merged as no owners are required for the pyproject.toml file.