Fix CLI datetime parsing to default date-only strings to midnight instead of current time#199
Closed
Fix CLI datetime parsing to default date-only strings to midnight instead of current time#199
Conversation
Author
|
@Marenz 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: Marenz <424752+Marenz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] CLI: Interpretation of "--end-time-to 2025-08-06" will use the current time instead of 00:00
Fix CLI datetime parsing to default date-only strings to midnight instead of current time
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI was incorrectly interpreting date-only strings like
--until 2025-08-06by using the current time instead of defaulting to 00:00:00 (midnight). This caused unexpected behavior where users expected the date to represent the start of the day.Problem
When using the CLI with date-only parameters, the
FuzzyDateTimeclass was usingparsedatetime.Calendar().parseDT()which defaults to the current time for the time component:Solution
Added intelligent detection of date-only strings using regex patterns to distinguish between:
2025-08-06,2025/08/06,08/06/2025,08-06-2025in 1 hour,tomorrow,in 2 daysFor date-only strings, the parser now uses a
sourceTimeparameter set to midnight, ensuring consistent behavior. Relative time expressions continue to use the current time as the reference point.Changes
FuzzyDateTime.convert()in_cli_types.pyto detect date-only patternsTesting
Fixes #198.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.