Conversation
Contributor
Marenz
commented
Jul 16, 2025
- Use correct form of logging
- Reset release notes
- Add Dispatch.started_at(now)
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
This way users can use a stable unchanging `now` across calls and be sure that the result is always in respect to the same `now` Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
There was a problem hiding this comment.
Pull Request Overview
Adds a new deterministic-start check for Dispatch, standardizes logging in fake service tests, and resets release notes to templates.
- Introduce
Dispatch.started_at(now: datetime)and updatestartedto delegate to it - Replace direct
logging.debugcalls with module-level_loggerin fake service tests - Clear out
RELEASE_NOTES.mdcontent and insert placeholder comments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/dispatch/types.py | Added started_at method and routed started through it |
| src/frequenz/client/dispatch/test/_service.py | Defined _logger and updated debug calls in streaming tests |
| RELEASE_NOTES.md | Reset notes and added placeholder comments for summary/upgrade |
Comments suppressed due to low confidence (2)
src/frequenz/client/dispatch/types.py:432
- No unit tests cover the new
started_atmethod. Add tests for scenarios before start, during active period, after end, inactive dispatches, and recurring dispatches to ensure correct behavior.
def started_at(self, now: datetime) -> bool:
RELEASE_NOTES.md:5
- Release notes are left as placeholders. Please provide a concise summary of the changes and upgrade instructions before merging.
<!-- Here goes a general summary of what this release is about -->
ela-kotulska-frequenz
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.