Update to use BaseId' ids#181
Merged
Marenz merged 2 commits intofrequenz-floss:v0.x.xfrom Jun 23, 2025
Merged
Conversation
github-actions
bot
added
part:tests
llucax
reviewed
Jun 13, 2025
github-actions
bot
added
the
part:tooling
Marenz
force-pushed
the
iddispatchididid
branch
2 times, most recently
from
01b207d to
b7fff27
Compare
Marenz
requested review from
florian-wagner-frequenz,
llucax and
stefan-brus-frequenz
and removed request for
florian-wagner-frequenz and
stefan-brus-frequenz
llucax
reviewed
Jun 18, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
LGTM, but the commit split is weird and I'm not sure if the new sleeps sneaked in accidentally or not.
I would keep all (and only) ID updates in one commit, and refactors in a different commit (the refactor commit is updating to use ID classes too).
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
iddispatchididid
branch
2 times, most recently
from
9009f52 to
5a84236
Compare
llucax
reviewed
Jun 18, 2025
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.