refactor: rename seeding/caching terminology to hosting#64
Open
refactor: rename seeding/caching terminology to hosting#64
Conversation
iduartgomez
approved these changes
Mar 30, 2026
Contributor
|
before merging this, have a PR ready in freenet core PR for merging it, and test out against this branch all works as intended |
Contributor
Author
|
@iduartgomez I have this branch prepared https://github.com/freenet/freenet-core/tree/refactor/rename-seeding-to-hosting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
freenet-stdlib still uses outdated "seeding" and "caching" terminology for contracts
a node stores locally. freenet-core already standardized on "hosting" (PR #3522),
but the stdlib types were out of scope and still use the old names, creating an
inconsistency across the ecosystem.
Solution
Rename all seeding/caching types and fields to use "hosting" terminology:
SystemMetrics.seeding_contractsSystemMetrics.hosting_contractsNodeQuery::ProximityCacheInfoNodeQuery::NeighborHostingInfoQueryResponse::ProximityCache(ProximityCacheInfo)QueryResponse::NeighborHosting(NeighborHostingInfo)struct ProximityCacheInfostruct NeighborHostingInfostruct ContractCacheEntrystruct ContractHostingEntrystruct NeighborCacheInfostruct NeighborHostingDetailstruct ProximityStatsstruct HostingStatsFields within renamed structs were also updated for consistency:
cache_hash→hosting_hashcached_since→hosted_sincecache_announces_sent/received→hosting_announces_sent/receivedavg_neighbor_cache_size→avg_neighbor_hosting_sizeBreaking change
Version bumped from
0.3.5→0.4.0because all renamed types and fieldsare public API. Downstream consumers (freenet-core, river) must update to
the new names.
Serde compatibility note
These types are used for local client → node diagnostics queries only (not
peer-to-peer wire protocol), so the field rename does not affect network
compatibility between nodes.
Testing
cargo test— 15 passed, 2 ignored (pre-existing)cargo check— clean compilationFixes
Closes freenet/freenet-core#3524 (stdlib portion)