Closed
Conversation
Member
huyenltnguyen
left a comment
There was a problem hiding this comment.
I'm hesitant to hit approve as Niraj is probably more qualified to review this change.
Though I wonder if we could handle the errors globally, in the Dio service as well / instead:
// In dio_service.dart
dio.interceptors.add(
InterceptorsWrapper(
onError: (DioException error, ErrorInterceptorHandler handler) async {
if (error.response?.statusCode == 401 ||
error.response?.statusCode == 403) {
await locator<AuthenticationService>().logout();
}
},
),
);| await fetchUser(); | ||
| } else { | ||
| log('message: No valid credentials found'); | ||
| logout(); |
Member
There was a problem hiding this comment.
Does this mean the logout logic has been missing the whole time? 😮
Member
Author
There was a problem hiding this comment.
Well it wasn't being checked when starting the app, otherwise it was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of the repo.Closes #XXXXX