fix/css-helper normalize selector spacing handling#558
fix/css-helper normalize selector spacing handling#558harshentau-spec wants to merge 6 commits intofreeCodeCamp:mainfrom
Conversation
|
Hi team, this PR fixes issue #64218 by normalizing selector spacing in |
that wasn't the issue. The issue was that selectors with |
Thanks for pointing this out. You're right — the original issue was about * selectors being matched even when not explicitly allowed in getStyleAny. My current changes focus on selector spacing normalization and JSDOM compatibility, but they do not yet explicitly prevent wildcard (*) selectors from matching unless they are included in the allowed selector list. I will update the implementation to ensure * and wildcard-based selectors are rejected unless explicitly passed, and add test coverage for this case. Thanks for catching this. |
|
Hi maintainers, I've addressed the review feedback by fixing wildcard selector handling and updating the tests accordingly. |
|
Please test locally, the PR is failing testing |
majestic-owl448
left a comment
majestic-owl448
left a comment
There was a problem hiding this comment.
The CI is failing
…their tests; revert unnecessary changes
harshentau-spec
force-pushed
the
fix/64218-css-helper-spacing
branch
from
d7bd3cd to
3fd0cbd
Compare
majestic-owl448
left a comment
majestic-owl448
left a comment
There was a problem hiding this comment.
please add a test where you pass a wildcard selector to getStyle but there isn't one at all in the css being tested, create a new css string in the file that contains them
|
closing this PR, it's not going anywhere |
2 participants
Checklist:
Update index.md)Closes freeCodeCamp/freeCodeCamp#64218
Description of changes:
css-helperto correctly handle selector spacing normalization.getStyleandgetStyleAnyto match selectors even with different spacing.