Add battery reporting feature#135
Open
caco3 wants to merge 1 commit into
Open
Conversation
- Send battery data and charging state to phone when they change - Add JavaScript handler to POST data to configured endpoint - Add message keys to package.json for battery data - Increase app_message outbox buffer size to 512 bytes - Update BASE_CONFIG_URL - Update README with battery reporting feature attribution
Member
|
Thanks for the MR, I appreciate the effort! That said, I'm not sure if there would be a lot of demand for a feature like this, especially what with Muninn's battery monitoring and export capabilities. |
Author
|
I see you point, but there are 2 different expectations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature got adapted from https://github.com/skylord123/ForeCal, see skylord123/pebble-home-assistant-ws#4 for details.
Also note #136 for the Configuration UI part!
If you want to merge it, don't forget to change back
BASE_CONFIG_URL!