Skip to content

Flow to xml inconsistencies #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matthbo merged 2 commits into from
Apr 15, 2026
Merged

Flow to xml inconsistencies #426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193cda9
Receivers now no longer generate forwards, exits persist their attrib…
Daan0709 Apr 7, 2026
06b396b
Merge branch 'master' into bug/receiver-forwards
Daan0709 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions src/main/frontend/app/routes/studio/flow-to-xml-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,18 +174,24 @@ function generateXmlElement(

const childXml = children.map((child: ChildNode) => generateChildXml(child, 4)).join('\n')

const forwards = (edgeMap.get(node.id) || [])
.map(({ label, targetId }) => {
const forwardTarget = nodeMap.get(targetId)
const targetName = (forwardTarget?.data as NodeData)?.name || ''
if (targetName === '') {
console.warn(`Target node with ID ${targetId} does not have a name attribute.`)
return ''
}
// If saving from flow to xml, all edges will be considered explicit Forwards.
return ` <Forward name="${escapeXml(label)}" path="${escapeXml(targetName)}" />`
})
.join('\n')
const type = (node.data as NodeData).type?.toLowerCase()

const forwards =
type === 'receiver'
? '' // Receivers should never have a <Forward> element
: (edgeMap.get(node.id) || [])
.map(({ label, targetId }) => {
const forwardTarget = nodeMap.get(targetId)
const targetName = (forwardTarget?.data as NodeData)?.name || ''

if (targetName === '') {
console.warn(`Target node with ID ${targetId} does not have a name attribute.`)
return ''
}

return ` <Forward name="${escapeXml(label)}" path="${escapeXml(targetName)}" />`
})
.join('\n')

const content = [childXml, forwards].filter(Boolean).join('\n')
return content
Expand Down Expand Up @@ -219,6 +225,7 @@ ${spaces}</${child.subtype}>`
function generateExitsXml(exitNodes: FlowNode[]): string {
return exitNodes
.map((node) => {
const { name } = node.data as NodeData
const data = node.data as NodeData
const { x, y } = node.position
const roundedX = Math.round(x)
Expand All @@ -229,23 +236,17 @@ function generateExitsXml(exitNodes: FlowNode[]): string {
width = node.measured.width
height = node.measured.height
}
const name = escapeXml(data.name)
const state = getExitState(data)
const attributes = data.attributes || {}
const flowNamespaceString = `flow:y="${roundedY}" flow:x="${roundedX}" flow:width="${width}" flow:height="${height}"`
const attributeString = ` name="${escapeXml(name)}"${Object.entries(attributes)
.map(([key, value]) => ` ${key}="${escapeXml(value)}"`)
.join('')}`

return ` <Exit name="${name}" state="${state}" ${flowNamespaceString} />`
return ` <Exit ${attributeString} ${flowNamespaceString} />`
})
.join('\n')
}

function getExitState(data: NodeData): string {
const storedState = data.attributes?.state
if (storedState) return storedState

const name = data.name.toLowerCase()
return name.includes('bad') || name.includes('fail') ? 'error' : 'success'
}

function generateFlowElementsXml(nodes: FlowNode[]): string {
const stickyNotes = nodes.filter((node) => isStickyNote(node))
const groupNodes = nodes.filter((node) => isGroupNode(node))
Expand Down
Loading