Add busy_timeout to verify! method to gracefully handle concurrent write locks - #74
Open
jonyoi wants to merge 1 commit into
Open
Add busy_timeout to verify! method to gracefully handle concurrent write locks#74jonyoi wants to merge 1 commit into
jonyoi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Litestream.verify! method opens a direct SQLite3::Database connection to insert a sentinel value and confirm replication. However, because this connection is created outside of Active Record's connection pool, it does not inherit the timeout configuration defined in database.yml.
In production environments with active, concurrent write load, the verification task's sentinel write can hit a momentary lock collision and immediately raise SQLite3::BusyException, causing the verification job to fail.
This PR adds a busy_timeout keyword argument (defaulting to 5000ms) to verify! and applies it to the raw connection before executing schema creation or inserts. This aligns the method's concurrency behaviour with standard Rails SQLite configurations and prevents false-positive job failures.
Changes: