feat: add ignored_error_codes_from option to Project and ProjectBuilder#361
Merged
zerosnacks merged 4 commits intofoundry-rs:mainfrom Mar 19, 2026
Merged
Conversation
ndavd
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
ndavd
changed the title
4 tasks
mattsse
approved these changes
Mar 19, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense
wdyt @grandizzy @DaniPopes
this is technically breaking but doesnt affect foundry so imo we can sneak this one in, dont think anyone uses the error fns directly
Comment on lines
939
to
944
| /// the error codes to ignore | ||
| ignored_error_codes: &'a [u64], | ||
| /// the error codes to ignore from each path prefix | ||
| ignored_error_codes_from: &'a [(PathBuf, Vec<u64>)], | ||
| /// the file paths to ignore | ||
| ignored_file_paths: &'a [PathBuf], |
Member
There was a problem hiding this comment.
now we have a bunch of ignore settings that we could extract but maybe not worth doing
grandizzy
approved these changes
Mar 19, 2026
Contributor
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
yep, should be good, ty! needs clippy fix
zerosnacks
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignored_error_codes_fromconfig option foundry#9516