fix(ci): allow OpenSSL license in cargo-deny and fix clippy iter_kv_map lint#359
Merged
zerosnacks merged 2 commits intomainfrom Mar 17, 2026
Merged
fix(ci): allow OpenSSL license in cargo-deny and fix clippy iter_kv_map lint#359zerosnacks merged 2 commits intomainfrom
zerosnacks merged 2 commits intomainfrom
Conversation
`aws-lc-sys` uses the OpenSSL license (via `ISC AND (Apache-2.0 OR ISC) AND OpenSSL`), which was not in the allow list, causing `cargo deny check` to fail. Also removes stale entries no longer present in the dependency tree: - `Unicode-DFS-2016` license allowance - `LicenseRef-ring` / `LicenseRef-webpki` license allowances and clarifications - `tiny-keccak` CC0-1.0 exception Amp-Thread-ID: https://ampcode.com/threads/T-019cfc11-1f81-72f3-87c5-542e7e79d0e9 Co-authored-by: Amp <amp@ampcode.com>
Fixes `clippy::iter_kv_map` lint on nightly for the `artifacts` and `into_artifacts` iterators. Amp-Thread-ID: https://ampcode.com/threads/T-019cfc11-1f81-72f3-87c5-542e7e79d0e9 Co-authored-by: Amp <amp@ampcode.com>
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
zerosnacks
changed the title
grandizzy
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two CI failures on
main:1.
cargo deny check— OpenSSL license rejectionaws-lc-sysuses the license expressionISC AND (Apache-2.0 OR ISC) AND OpenSSL. TheOpenSSLlicense was not in thedeny.tomlallow list, causing the check to fail.Fix: Add
OpenSSLto the allowed licenses list. Also removes stale entries no longer present in the dependency tree:Unicode-DFS-2016license allowanceLicenseRef-ring/LicenseRef-webpkilicense allowances and clarificationstiny-keccakCC0-1.0exception2.
clippy—iter_kv_maplint (nightly)Two instances in
crates/compilers/src/artifact_output/mod.rsiterate over map entries but discard the key.Fix: Use
.values()/.into_values()instead of.iter()/.into_iter()with unused keys.