fix: match ephemeral server address family - #896
Open
pnookala-godaddy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
serverAddress()currently starts an ephemeral server withlisten(0)but always connects to127.0.0.1. On macOS, Node commonly binds that server to the IPv6 wildcard. A separate process can own the same port specifically on IPv4, causing Supertest's request to reach the foreign process.This keeps the existing synchronous ephemeral bind and uses only public Node APIs. IPv6 addresses are bracketed for URL construction, and wildcard addresses are converted to their same-family loopback equivalents.
Fixes #894
Testing
npm teston Node 24: 131 passing, including lint and coverageforeign-serverinstead ofsupertest-server