Add exponential backoff retry for SSC 502/503 errors addressing temporary server errors without stopping fcli#936
Open
gilseara wants to merge 2 commits intofortify:dev/v3.xfrom
Open
Conversation
Add SSCRetryStrategy implementing Apache HttpClient's ServiceUnavailableRetryStrategy to retry on HTTP 502 (Bad Gateway) and 503 (Service Unavailable) with exponential backoff (1s, 2s, 4s) and random jitter (0-500ms). Wire it into the SSC unirest instance via a custom ApacheClient, following the existing FoD retry pattern.
rsenden
reviewed
Mar 9, 2026
Contributor
rsenden
left a comment
rsenden
left a comment
There was a problem hiding this comment.
Two questions:
- Is there any risk of POST/PUT/DELETE operations being repeated, causing for example two new entities to be created in SSC rather than just one? Possibly safer to only retry GET requests?
- Should we apply the same retry strategy to SC-SAST/SC-DAST, and maybe also replicate to FoD?
gilseara
force-pushed
the
feature/ssc-retry-502-503
branch
2 times, most recently
from
feb0c1b to
d0b5dbc
Compare
Only retry GET requests on 502/503 to avoid duplicate side effects from retrying non-idempotent operations. Apply the same retry strategy to SC-SAST and SC-DAST unirest instances, and add 502/503 GET-only retry to FoDRetryStrategy alongside the existing 404/429 handling.
Contributor
Author
|
@rsenden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SSCRetryStrategy implementing Apache HttpClient's ServiceUnavailableRetryStrategy to retry on HTTP 502 (Bad Gateway) and 503 (Service Unavailable) with exponential backoff (1s, 2s, 4s) and random jitter (0-500ms). Wire it into the SSC unirest instance via a custom ApacheClient, following the existing FoD retry pattern.