Skip to content

Added "Largest Term" to stats for On SortVerbose#875

Open
Emaiks wants to merge 1 commit into
form-dev:masterfrom
Emaiks:getmaxtermsize
Open

Added "Largest Term" to stats for On SortVerbose#875
Emaiks wants to merge 1 commit into
form-dev:masterfrom
Emaiks:getmaxtermsize

Conversation

@Emaiks

@Emaiks Emaiks commented Jul 14, 2026

Copy link
Copy Markdown

Added a new line to the statistics message in case of On SortVerbose that shows the maximal term size needed in the past module. For that the maximal term size was checked in:

  • AddWithFloat
  • AddCoef
  • AddPoly
  • StoreTerm
  • Normalize (at 2 places: before normalization and after)

The value will be compared between threads and printed out. No large check have been done.

@jodavies

Copy link
Copy Markdown
Collaborator

It seems that Normalize can be called, before the associated sorting struct is properly initialised. The failing tests all look like they use putinside or antiputinside before any function arguments appear in the input. Maybe those functions should make sure a sub-buffer sorting struct is ready before processing anything, rather than removing your termsize checks from Normalize. I'll take a look.

@jodavies

Copy link
Copy Markdown
Collaborator

@Emaiks can you wrap the term-size checks in Normalize with if ( AT.SS == AT.S0 ) {}? I think it should suffice to only track the ground-level maximal size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants