Open
Conversation
This lock is initialised in a few places, but never locked/unlocked. Rename pthreadslockread as pthreadslock, since it is (and always has been) used for both reading and writing.
The fix of form-dev#797 causes deadlocks when assigned MODMAX or MODMIN dollars appear on their RHS, inside a function argument. In that case, another lock on the dollar is attempted. For example: `$dol = max_($dol,something);` Use PTHREAD_MUTEX_RECURSIVE for dollar variables, such that a thread may re-lock a dollar during assignment operations. The MODSUM case has always deadlocked for such constructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix of #797 causes deadlocks when assigned MODMAX or MODMIN
dollars appear on their RHS, inside a function argument. In that
case, another lock on the dollar is attempted.
For example:
$dol = max_($dol,something);Use PTHREAD_MUTEX_RECURSIVE for dollar variables, such that a
thread may re-lock a dollar during assignment operations.
The MODSUM case has always deadlocked for such constructions.
This also removes
pthreadslockwrite, which is unused, and renamespthreadslockreadaspthreadslock.This is about a 1% performance regression for fmft, mincer, minceex benchmarks (which should be largely recovered by #807).
I added test cases for the example of #271 in both tform and parform variants, which do not behave in the same way.