Skip to content

CHANGE @W-22393694@ - bug fix on org and alias #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhil-mittal-165 merged 2 commits into from
Jul 10, 2026
Merged

CHANGE @W-22393694@ - bug fix on org and alias #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fc825
bug fix on org and alias
nikhil-mittal-165 Jul 10, 2026
04fa6e1
Merge branch 'dev' into apexguru-bug-fix
nikhil-mittal-165 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/actions/RunAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {AuthInfo, SfError} from '@salesforce/core';
import {Org, SfError} from '@salesforce/core';
import {
CodeAnalyzer,
CodeAnalyzerConfig,
Expand Down Expand Up @@ -120,7 +120,7 @@ export class RunAction {

private async validateTargetOrg(orgNameOrAlias: string): Promise<void> {
try {
await AuthInfo.create({ username: orgNameOrAlias });
await Org.create({ aliasOrUsername: orgNameOrAlias });
} catch (error) {
if (error instanceof Error) {
const errorMessage = [
Expand Down
26 changes: 13 additions & 13 deletions test/lib/actions/RunAction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as path from 'node:path';
import * as fs from 'node:fs';
import ansis from 'ansis';
import {AuthInfo, SfError} from '@salesforce/core';
import {Org, SfError} from '@salesforce/core';
import {SeverityLevel} from '@salesforce/code-analyzer-core';
import {SpyResultsViewer} from '../../stubs/SpyResultsViewer.js';
import {SpyResultsWriter} from '../../stubs/SpyResultsWriter.js';
Expand Down Expand Up @@ -482,8 +482,8 @@ describe('RunAction tests', () => {

describe('target-org', () => {
it('RunInput accepts target-org field', async () => {
// Mock AuthInfo.create to succeed
vi.spyOn(AuthInfo, 'create').mockResolvedValue({} as AuthInfo);
// Mock Org.create to succeed
vi.spyOn(Org, 'create').mockResolvedValue({} as Org);

const input: RunInput = {
'rule-selector': ['all'],
Expand All @@ -499,8 +499,8 @@ describe('RunAction tests', () => {
});

it('target-org is passed through to engine config', async () => {
// Mock AuthInfo.create to succeed
vi.spyOn(AuthInfo, 'create').mockResolvedValue({} as AuthInfo);
// Mock Org.create to succeed
vi.spyOn(Org, 'create').mockResolvedValue({} as Org);

const targetOrg = 'my-test-org';
const configFactorySpy = vi.spyOn(dependencies.configFactory, 'create');
Expand All @@ -525,7 +525,7 @@ describe('RunAction tests', () => {

it('validates org authentication before config creation', async () => {
const targetOrg = 'test-org';
const authInfoSpy = vi.spyOn(AuthInfo, 'create').mockResolvedValue({} as AuthInfo);
const orgSpy = vi.spyOn(Org, 'create').mockResolvedValue({} as Org);

const input: RunInput = {
'rule-selector': ['all'],
Expand All @@ -536,14 +536,14 @@ describe('RunAction tests', () => {

await action.execute(input);

// Verify AuthInfo.create was called with the org name
expect(authInfoSpy).toHaveBeenCalledWith({ username: targetOrg });
// Verify Org.create was called with the org alias/username
expect(orgSpy).toHaveBeenCalledWith({ aliasOrUsername: targetOrg });
});

it('throws clear error when org is not authenticated', async () => {
const targetOrg = 'unauthenticated-org';
// Mock AuthInfo.create to throw an error (org not found/authenticated)
vi.spyOn(AuthInfo, 'create').mockRejectedValue(new Error('No authorization information found'));
// Mock Org.create to throw an error (org not found/authenticated)
vi.spyOn(Org, 'create').mockRejectedValue(new Error('No authorization information found'));

const input: RunInput = {
'rule-selector': ['all'],
Expand All @@ -569,7 +569,7 @@ describe('RunAction tests', () => {
});

it('does not validate org when target-org is not provided', async () => {
const authInfoSpy = vi.spyOn(AuthInfo, 'create');
const orgSpy = vi.spyOn(Org, 'create');

const input: RunInput = {
'rule-selector': ['all'],
Expand All @@ -580,8 +580,8 @@ describe('RunAction tests', () => {

await action.execute(input);

// Verify AuthInfo.create was NOT called
expect(authInfoSpy).not.toHaveBeenCalled();
// Verify Org.create was NOT called
expect(orgSpy).not.toHaveBeenCalled();
});
});
});
Expand Down
Loading