NEW @W-23442992@ [Bug Bounty / H1]Salesforce Code Analyzer custom_engine_plugin_modules hidden config key#483
Open
nikhil-mittal-165 wants to merge 1 commit into
Conversation
…ePlugin (RCE fix) Remove the undocumented custom_engine_plugin_modules config field and the dynamicallyAddEnginePlugin method that together enabled arbitrary code execution via dynamic import of user-controlled paths. - Remove CUSTOM_ENGINE_PLUGIN_MODULES from FIELDS, TopLevelConfig type, DEFAULT_CONFIG, and bypass-validation list so the field is now actively rejected by schema validation as an invalid key - Remove getCustomEnginePluginModules() accessor from CodeAnalyzerConfig - Remove dynamicallyAddEnginePlugin() method and dynamicallyImport() helper from CodeAnalyzer class - Remove pathToFileURL import (no longer needed) - Remove FailedToDynamicallyLoadModule and FailedToDynamicallyAddEnginePlugin error messages - Add security tests asserting config rejection and method absence - Update test fixtures and existing tests for removed functionality
|
Git2Gus App is installed but the |
nikhil-mittal-165
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the hidden
custom_engine_plugin_modulesconfiguration key and dynamically loaded engine plugin functionality to eliminate a Remote Code Execution (RCE) vulnerability. This security fix blocks the ability to inject and execute arbitrary code through malicious config files.GUS Ticket W-23442992 — [Bug Bounty / H1]Salesforce Code Analyzer custom_engine_plugin_modules hidden config key
Changes
custom_engine_plugin_moduleshidden config key from CodeAnalyzerConfigdynamicallyAddEnginePluginmethod from CodeAnalyzer prototypeDependencies
None
Test Evidence
Unit tests: code-analyzer-core 435/435 pass (15 suites)
Integration: dreamhouse baseline scan fails with 'config.getCustomEnginePluginModules is not a function' because CLI repo still calls removed API (Category B - CLI needs separate PR)
Security validation PASS:
Known external failures (not blocking): CLI repo (code-analyzer) still calls getCustomEnginePluginModules() in ConfigAction.ts/RulesAction.ts/RunAction.ts - needs separate CLI PR to remove those calls
Test Status: PASS
Fix attempts: 0